Can you include this:
If you could that would be great, also give me credit in this format:
Christian Thone, 2018
[Link To The Repl]
[Your Name] + is using this project with the creators permission.
@Ryanand I would like to help with this project, here comes my personal todo list for it:
- Everywhere where you have
echo hello there;replace it with
echo "hello there";, it's safer and more compatible with multiple versions of Shell
- On multiple places in your python code you have the following code block:
bashCommand = "bash somerandombashfile.sh;" os.system(bashCommand)
There is no need for the extra variable
bashCommand. It only makes your code harder to read and takes more memory. You should change it to;
- For example, because you did this, this slipped into your code in
15-17(I copied this directly from the file):
bashCommand = "chmod +x textexample.sh;" bashCommand = "bash textexample.sh;" os.system(bashCommand)
If you look carefully at what you did here, you will see that you assigned the value
"chmod +x textexample.sh;" to
bashCommand, but then you reassigned
"bash textexample.sh;". So when you called
chmod +x textexample.sh; would never be executed...
- Note that this is also the case for the following positions in your code:
- Oh, and you should probably update the
/backupfolder with your most recent code xD
I do need to say that this is positive criticism!! I absolutely love what your doing and keep up the good work!
Is it possible to have Python files in TestOS2?
maybe actually make a proper OS?
@HappyFakeboulde hbf your comments have been real condescending recently. I think everybody would appreciate proper feedback rather than these gatekeeper remarks (mind, you haven't made any proper operating systems yourself either). People here are eager to learn and share their projects and they deserve every inch of respect you'd wish to receive yourself. All I ask is you keep these sort of comments to yourself if you're not to contribute to the discussion.
@HappyFakeboulde Yeah! You went from the harmless joke 'we have technology' in HOS from me to THIS stuff when you see OS in the title of something. Now stop trying to make everyone else look bad and you look good. Even a week ago in Nano DOS from @JayBFC, you were giving constructive criticism, now your just acting like a jerk towards other people... It's ok to think that this isn't a real OS, I know I do when it comes to mine, but whats not ok is when you share those thoughts to other people in a horrible way, like using bold characters right there.
@HappyFakeboulde Criticism is criticism, but you get to decide how you want to phrase it. All things can be said in a rude way or in a polite way.
"Your operating system sucks, make a real operating system" and
"Your operating system could use some work. You should look into what some real operating systems do and try to implement some of those features!" both convey the same message,
"Good start, could be better" but the first one is unhelpful and makes you look bad while the second one makes it clear what your concern is. If your goal is to speak your mind, by all means-- do so. But being an ass about it isn't a great way for people to care or listen.